Skip to content

🎨 Expose wallet_id to computational and dynamic services via env vars upon request #7125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 29, 2025
Merged

🎨 Expose wallet_id to computational and dynamic services via env vars upon request #7125

merged 9 commits into from
Jan 29, 2025

Conversation

@GitHK
Copy link
Contributor

@GitHK GitHK commented Jan 28, 2025 •
edited
Loading

What do these changes do?

It is now possible to request the wallet_id via OSPARC_VARIABLE_WALLET_ID inside a service.

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Jan 28, 2025
@GitHK GitHK added a:director-v2 issue related with the director-v2 service 🤖-automerge marks PR as ready to be merged for Mergify labels Jan 28, 2025
@GitHK GitHK added this to the Singularity milestone Jan 28, 2025
@GitHK GitHK marked this pull request as ready for review January 28, 2025 16:31
mguidon
mguidon reviewed Jan 28, 2025
View reviewed changes
Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@codecov
Copy link

codecov bot commented Jan 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.59%. Comparing base (1713021) to head (14a959c).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (1713021) and HEAD (14a959c). Click for more details.

HEAD has 29 uploads less than BASE
Flag BASE (1713021) HEAD (14a959c)
unittests 30 1
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #7125       +/-   ##
===========================================
- Coverage   87.53%   70.59%   -16.95%     
===========================================
  Files        1635      637      -998     
  Lines       63872    30924    -32948     
  Branches     2053      262     -1791     
===========================================
- Hits        55913    21832    -34081     
- Misses       7622     9032     +1410     
+ Partials      337       60      -277
Flag Coverage Δ
integrationtests 64.66% <100.00%> (+1.08%) ⬆️
unittests 84.58% <100.00%> (-1.36%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.37% <ø> (-8.02%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 91.27% <100.00%> (+<0.01%) ⬆️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.59% <ø> (-0.13%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.28% <ø> (-26.55%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1713021...14a959c. Read the comment docs.

pcrespov
pcrespov approved these changes Jan 28, 2025
View reviewed changes
sanderegg
sanderegg approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

matusdrobuliak66
matusdrobuliak66 approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@GitHK GitHK changed the title 🎨 Espose wallet_id to computational and dynamic services via env vars upon request 🎨 Expose wallet_id to computational and dynamic services via env vars upon request Jan 29, 2025
@GitHK
Copy link
Contributor Author

GitHK commented Jan 29, 2025

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Jan 29, 2025 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 1433e6e

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 29, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mergify mergify bot merged commit 1433e6e into ITISFoundation:master Jan 29, 2025
91 of 95 checks passed
@GitHK GitHK deleted the pr-osparc-add-wallet-id-to-osparc-envs branch January 29, 2025 14:23
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 30, 2025
Closed
16 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Mar 6, 2025
Closed
63 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mguidon mguidon mguidon left review comments

@pcrespov pcrespov pcrespov approved these changes

@sanderegg sanderegg sanderegg approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

Assignees

@GitHK GitHK

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:director-v2 issue related with the director-v2 service

Projects

None yet

Milestone

Singularity

Development

Successfully merging this pull request may close these issues.

We need to pass WALLET_ID as an environment variable to the Sim4Life app

5 participants

@GitHK @pcrespov @mguidon @sanderegg @matusdrobuliak66